Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KUBESAW-174: Print error output for repos where verification failed #458

Merged
merged 13 commits into from
Jan 31, 2025

Conversation

fbm3307
Copy link
Contributor

@fbm3307 fbm3307 commented Jan 20, 2025

Description

This PR is to update the verify dependency script such a way that it prints the error/failure in an understandable way

Checks

  1. Did you run make generate target? NA

  2. Did make generate change anything in other projects (host-operator, member-operator)? NA

  3. In case of new CRD, did you the following? NA

  4. In case other projects are changed, please provides PR links.

Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Copy link
Contributor

@mfrancisc mfrancisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

I have one minor comment about the regex.

scripts/verify-replace.sh Outdated Show resolved Hide resolved
@fbm3307 fbm3307 requested a review from mfrancisc January 21, 2025 10:56
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
scripts/verify-replace.sh Outdated Show resolved Hide resolved
scripts/verify-replace.sh Outdated Show resolved Hide resolved
scripts/verify-replace.sh Outdated Show resolved Hide resolved
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Copy link
Contributor

@metlos metlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good apart from some minor comments.

scripts/verify-replace.sh Outdated Show resolved Hide resolved
scripts/verify-replace.sh Outdated Show resolved Hide resolved
scripts/verify-replace.sh Outdated Show resolved Hide resolved
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307 fbm3307 requested review from metlos and mfrancisc January 27, 2025 12:15
scripts/verify-replace.sh Outdated Show resolved Hide resolved
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307 fbm3307 requested a review from metlos January 30, 2025 05:55
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
scripts/verify-replace.sh Outdated Show resolved Hide resolved
Signed-off-by: Feny Mehta <fbm3307@gmail.com>
@fbm3307 fbm3307 merged commit 086c0df into codeready-toolchain:master Jan 31, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants